.
Details
Yesterday
@STran can this be closed now or does it need to be moved into the next sprint for more work?
Fri, Oct 3
Thu, Oct 2
This is still waiting on code review. It will need some additional follow-up there, but that is currently not a priority for us.
Mon, Sep 29
Fri, Sep 26
Thu, Sep 25
Change #1178658 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] only show edit email from epc if donor never made donation with paypal
Change #1190389 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Only parse and process the HTML if it seems to contain our tags (for topic subscriptions)
Tue, Sep 23
Change #1190606 merged by Reedy:
[mediawiki/extensions/WebAuthn@REL1_43] Fix multi-key handling
Change #1190606 merged by Reedy:
[mediawiki/extensions/WebAuthn@REL1_43] Fix multi-key handling
Change #1190762 merged by Reedy:
[mediawiki/extensions/WebAuthn@REL1_43] Implement function to get module from key
Change #1190762 had a related patch set uploaded (by Reedy; author: Majavah):
[mediawiki/extensions/WebAuthn@REL1_43] Implement function to get module from key
Change #1190746 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_43] Fix multi-key handling
Change #1190745 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_43] Mark OATHUser::getModule() as deprecated
Change #1190741 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_43] OATHManage: Drop use of OATHUser::getModule()
Change #1190746 had a related patch set uploaded (by Reedy; author: Gergő Tisza):
[mediawiki/extensions/OATHAuth@REL1_43] Fix multi-key handling
Change #1190745 had a related patch set uploaded (by Reedy; author: Majavah):
[mediawiki/extensions/OATHAuth@REL1_43] Mark OATHUser::getModule() as deprecated
Change #1190741 had a related patch set uploaded (by Reedy; author: Majavah):
[mediawiki/extensions/OATHAuth@REL1_43] OATHManage: Drop use of OATHUser::getModule()
Change #1190630 merged by jenkins-bot:
[mediawiki/extensions/OATHAuth@REL1_43] Backlink keys back to a module
Change #1190630 had a related patch set uploaded (by Reedy; author: Majavah):
[mediawiki/extensions/OATHAuth@REL1_43] Backlink keys back to a module
Change #1190593 merged by Reedy:
[mediawiki/extensions/WebAuthn@REL1_44] Fix multi-key handling
Change #1190593 merged by Reedy:
[mediawiki/extensions/WebAuthn@REL1_44] Fix multi-key handling
Change #1190606 had a related patch set uploaded (by Reedy; author: Gergő Tisza):
[mediawiki/extensions/WebAuthn@REL1_43] Fix multi-key handling
Change #1190606 had a related patch set uploaded (by Reedy; author: Gergő Tisza):
[mediawiki/extensions/WebAuthn@REL1_43] Fix multi-key handling
Change #1190593 had a related patch set uploaded (by Reedy; author: Gergő Tisza):
[mediawiki/extensions/WebAuthn@REL1_44] Fix multi-key handling
Change #1190593 had a related patch set uploaded (by Reedy; author: Gergő Tisza):
[mediawiki/extensions/WebAuthn@REL1_44] Fix multi-key handling
Change #1190389 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Only parse and process the HTML if it seems to contain our tags (for topic subscriptions)
I had a look and I don't think that would be easy to do. DiscussionTools adds some markup (<mw:dt-ellipsisbutton>) for every heading on the page in the ParserAfterTidy hook, even if it has no comments, and so the OutputPageBeforeHTML hook needs to postprocess that markup. Maybe this could be refactored somehow, as currently in the majority of cases the latter hook ends up just removing that markup, but this seems a bit complex and easy to get wrong (especially in case we end up changing the configuration in the future so that the markup is used more often). The current approach where we return early only if there is no DiscussionTools markup at all is safer, and seems good enough to me.
Mon, Sep 22
Sun, Sep 21
Thanks for testing and logging the associated bug (which has been fixed: T403558).
I think we can consider this resolved. We've done more than investigate and actually released GrowthExperiments to Beta Wikidata where WMDE and community members are reviewing and deciding if/when they want to add Growth features to WikiData.
Testing is done - moving to Blocked column for deciding on the next steps.
Sat, Sep 20
I have an idea for follow-up: Can the OutputPageBeforeHTML hook return early if the ParserAfterTidy hook does not find any comment during Parser::parse()? It would be helpful for those content pages in $wgExtraSignatureNamespaces, which can be long sometimes. This does not concern the talk namespaces, and I guess the "empty state" UI elements might depend on it.
Fri, Sep 19
Apparently the “merge conflict” from T400918#11086095 can happen even when no files were being added, as seen in PS3 of this change.
Thu, Sep 18
Wed, Sep 17
Makes it a bit hard to tell the difference between the first strikethrough (not previously elected) and the second strikethrough (previously elected). Can we go a bit darker on the color?
Tue, Sep 16
Change #1172901 abandoned by Reedy:
[mediawiki/extensions/OATHAuth@master] Allow using multiple modules